1
0
mirror of https://github.com/pcvolkmer/etl-processor.git synced 2025-04-19 17:26:51 +00:00

Add human readable data quality report

This commit is contained in:
Paul-Christian Volkmer 2023-07-26 08:39:58 +02:00
parent cd20e0a170
commit 26312c8620
4 changed files with 77 additions and 2 deletions

View File

@ -20,6 +20,7 @@
package dev.dnpm.etl.processor.config package dev.dnpm.etl.processor.config
import com.fasterxml.jackson.databind.ObjectMapper import com.fasterxml.jackson.databind.ObjectMapper
import dev.dnpm.etl.processor.monitoring.ReportService
import dev.dnpm.etl.processor.output.KafkaMtbFileSender import dev.dnpm.etl.processor.output.KafkaMtbFileSender
import dev.dnpm.etl.processor.output.MtbFileSender import dev.dnpm.etl.processor.output.MtbFileSender
import dev.dnpm.etl.processor.output.RestMtbFileSender import dev.dnpm.etl.processor.output.RestMtbFileSender
@ -82,6 +83,11 @@ class AppConfiguration {
return KafkaMtbFileSender(kafkaTemplate, objectMapper) return KafkaMtbFileSender(kafkaTemplate, objectMapper)
} }
@Bean
fun reportService(objectMapper: ObjectMapper): ReportService {
return ReportService(objectMapper)
}
@Bean @Bean
fun statisticsUpdateProducer(): Sinks.Many<Any> { fun statisticsUpdateProducer(): Sinks.Many<Any> {
return Sinks.many().multicast().directBestEffort() return Sinks.many().multicast().directBestEffort()

View File

@ -0,0 +1,51 @@
/*
* This file is part of ETL-Processor
*
* Copyright (c) 2023 Comprehensive Cancer Center Mainfranken, Datenintegrationszentrum Philipps-Universität Marburg and Contributors
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published
* by the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
package dev.dnpm.etl.processor.monitoring
import com.fasterxml.jackson.annotation.JsonValue
import com.fasterxml.jackson.databind.JsonMappingException
import com.fasterxml.jackson.databind.ObjectMapper
class ReportService(
private val objectMapper: ObjectMapper
) {
fun deserialize(dataQualityReport: String?): List<Issue> {
if (dataQualityReport.isNullOrBlank()) {
return listOf()
}
return try {
objectMapper.readValue(dataQualityReport, DataQualityReport::class.java).issues
} catch (e: JsonMappingException) {
e.printStackTrace()
listOf()
}
}
private data class DataQualityReport(val issues: List<Issue>)
data class Issue(val severity: Severity, val message: String)
enum class Severity(@JsonValue val value: String) {
ERROR("error"),
WARNING("warning"),
}
}

View File

@ -20,6 +20,7 @@
package dev.dnpm.etl.processor.web package dev.dnpm.etl.processor.web
import dev.dnpm.etl.processor.NotFoundException import dev.dnpm.etl.processor.NotFoundException
import dev.dnpm.etl.processor.monitoring.ReportService
import dev.dnpm.etl.processor.monitoring.RequestId import dev.dnpm.etl.processor.monitoring.RequestId
import dev.dnpm.etl.processor.monitoring.RequestRepository import dev.dnpm.etl.processor.monitoring.RequestRepository
import org.springframework.stereotype.Controller import org.springframework.stereotype.Controller
@ -31,7 +32,8 @@ import org.springframework.web.bind.annotation.RequestMapping
@Controller @Controller
@RequestMapping(path = ["/"]) @RequestMapping(path = ["/"])
class HomeController( class HomeController(
private val requestRepository: RequestRepository private val requestRepository: RequestRepository,
private val reportService: ReportService
) { ) {
@GetMapping @GetMapping
@ -46,6 +48,7 @@ class HomeController(
fun report(@PathVariable id: RequestId, model: Model): String { fun report(@PathVariable id: RequestId, model: Model): String {
val request = requestRepository.findByUuidEquals(id.toString()).orElse(null) ?: throw NotFoundException() val request = requestRepository.findByUuidEquals(id.toString()).orElse(null) ?: throw NotFoundException()
model.addAttribute("request", request) model.addAttribute("request", request)
model.addAttribute("issues", reportService.deserialize(request.report?.dataQualityReport))
return "report" return "report"
} }

View File

@ -35,7 +35,22 @@
</table> </table>
<h2 th:text="${request.report.description}"></h2> <h2 th:text="${request.report.description}"></h2>
<div class="chart monospace" th:text="${request.report.dataQualityReport}"></div>
<table th:if="not ${issues.isEmpty()}">
<thead>
<tr>
<th>Schweregrad</th>
<th>Beschreibung</th>
</tr>
</thead>
<tbody>
<tr th:each="issue : ${issues}">
<td th:if="${issue.severity.value == 'warning'}" class="bg-yellow"><small>[[ ${issue.severity} ]]</small></td>
<td th:if="${issue.severity.value == 'error'}" class="bg-red"><small>[[ ${issue.severity} ]]</small></td>
<td>[[ ${issue.message} ]]</td>
</tr>
</tbody>
</table>
</main> </main>
<script th:src="@{/scripts.js}"></script> <script th:src="@{/scripts.js}"></script>
</body> </body>