pcvolkmer/etl-processor
1
0
Fork 0
mirror of https://github.com/pcvolkmer/etl-processor.git synced 2025-04-20 01:36:50 +00:00
Code Issues Releases Activity

fix: add info severity to data quality report

Browse Source
This commit is contained in:
Paul-Christian Volkmer 2023-12-05 14:22:02 +01:00
parent 8dee349c37
commit ced6609d9a
4 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/main/kotlin/dev/dnpm/etl/processor/monitoring/ReportService.kt
View File

@ -56,5 +56,6 @@ class ReportService(
enum class Severity(@JsonValue val value: String) { enum class Severity(@JsonValue val value: String) {
ERROR("error"), ERROR("error"),
WARNING("warning"), WARNING("warning"),
INFO("info")
} }
} }

12
src/main/resources/static/style.css
View File

@ -1,6 +1,9 @@
:root { :root {
--table-border: rgba(96, 96, 96, 1); --table-border: rgba(96, 96, 96, 1);
--bg-blue: rgb(0, 74, 157);
--bg-blue-op: rgba(0, 74, 157, .35);
--bg-green: rgb(0, 128, 0); --bg-green: rgb(0, 128, 0);
--bg-green-op: rgba(0, 128, 0, .35); --bg-green-op: rgba(0, 128, 0, .35);
@ -181,6 +184,15 @@ td {
font-family: monospace; font-family: monospace;
} }
td.bg-blue, th.bg-blue {
background: var(--bg-blue);
color: white;
}
tr:has(td.bg-blue) {
background: var(--bg-blue-op);
}
td.bg-green, th.bg-green { td.bg-green, th.bg-green {
background: var(--bg-green); background: var(--bg-green);
color: white; color: white;

1
src/main/resources/templates/report.html
View File

@ -45,6 +45,7 @@
</thead> </thead>
<tbody> <tbody>
<tr th:each="issue : ${issues}"> <tr th:each="issue : ${issues}">
<td th:if="${issue.severity.value == 'info'}" class="bg-blue"><small>[[ ${issue.severity} ]]</small></td>
<td th:if="${issue.severity.value == 'warning'}" class="bg-yellow"><small>[[ ${issue.severity} ]]</small></td> <td th:if="${issue.severity.value == 'warning'}" class="bg-yellow"><small>[[ ${issue.severity} ]]</small></td>
<td th:if="${issue.severity.value == 'error'}" class="bg-red"><small>[[ ${issue.severity} ]]</small></td> <td th:if="${issue.severity.value == 'error'}" class="bg-red"><small>[[ ${issue.severity} ]]</small></td>
<td>[[ ${issue.message} ]]</td> <td>[[ ${issue.message} ]]</td>

7
src/test/kotlin/dev/dnpm/etl/processor/services/ReportServiceTest.kt
View File

@ -41,6 +41,7 @@ class ReportServiceTest {
{ {
"patient": "4711", "patient": "4711",
"issues": [ "issues": [
{ "severity": "info", "message": "Info Message" },
{ "severity": "warning", "message": "Warning Message" }, { "severity": "warning", "message": "Warning Message" },
{ "severity": "error", "message": "Error Message" } { "severity": "error", "message": "Error Message" }
] ]
@ -50,8 +51,10 @@ class ReportServiceTest {
val actual = this.reportService.deserialize(json) val actual = this.reportService.deserialize(json)
assertThat(actual).hasSize(2) assertThat(actual).hasSize(2)
assertThat(actual[0].severity).isEqualTo(ReportService.Severity.WARNING) assertThat(actual[0].severity).isEqualTo(ReportService.Severity.INFO)
assertThat(actual[0].message).isEqualTo("Warning Message") assertThat(actual[0].message).isEqualTo("Info Message")
assertThat(actual[1].severity).isEqualTo(ReportService.Severity.WARNING)
assertThat(actual[1].message).isEqualTo("Warning Message")
assertThat(actual[1].severity).isEqualTo(ReportService.Severity.ERROR) assertThat(actual[1].severity).isEqualTo(ReportService.Severity.ERROR)
assertThat(actual[1].message).isEqualTo("Error Message") assertThat(actual[1].message).isEqualTo("Error Message")
} }