From f5aff88758cc380567cd543368a9b84a6d435153 Mon Sep 17 00:00:00 2001
From: Jakub Lidke <jakub.lidke@uni-marburg.de>
Date: Thu, 17 Jul 2025 11:29:55 +0200
Subject: [PATCH] fix: throw unexpected exception in case gaps returns other
 than 2xx Code

---
 .../etl/processor/pseudonym/GpasPseudonymGenerator.java     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/dev/dnpm/etl/processor/pseudonym/GpasPseudonymGenerator.java b/src/main/java/dev/dnpm/etl/processor/pseudonym/GpasPseudonymGenerator.java
index 1997b64..a22100b 100644
--- a/src/main/java/dev/dnpm/etl/processor/pseudonym/GpasPseudonymGenerator.java
+++ b/src/main/java/dev/dnpm/etl/processor/pseudonym/GpasPseudonymGenerator.java
@@ -114,21 +114,21 @@ public class GpasPseudonymGenerator implements Generator {
                     String.class));
             if (responseEntity.getStatusCode().is2xxSuccessful()) {
                 log.debug("API request succeeded. Response: {}", responseEntity.getStatusCode());
+                return responseEntity;
             }
-            return responseEntity;
         } catch (RestClientException rce) {
             if (rce instanceof BadRequest) {
                 String msg = "gPas or request configuration is incorrect. Please check both."
                     + rce.getMessage();
                 log.debug(
                     msg);
-                throw new PseudonymRequestFailed(msg);
+                throw new PseudonymRequestFailed(msg, rce);
             }
             if (rce instanceof Unauthorized) {
                 var msg = "gPas access credentials are invalid  check your configuration. msg:  '%s".formatted(
                     rce.getMessage());
                 log.error(msg);
-                throw new PseudonymRequestFailed(msg);
+                throw new PseudonymRequestFailed(msg, rce);
             }
         } catch (Exception unexpected) {
             throw new PseudonymRequestFailed(