pcvolkmer/onkostar-plugin-dnpm
1
0
Fork 0
mirror of https://github.com/pcvolkmer/onkostar-plugin-dnpm.git synced 2025-07-03 09:42:54 +00:00
Code Issues Activity

Prüfe Eingabe der Methode updateEmpfehlungPrio()

Browse Source
This commit is contained in:
Paul-Christian Volkmer
2023-03-28 11:34:20 +02:00
parent 46d6892359
commit 9b44e3660a
2 changed files with 74 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/main/java/DNPM/DNPMHelper.java
View File

@ -223,25 +223,28 @@ public class DNPMHelper implements IProcedureAnalyzer {
} }
public Object updateEmpfehlungPrio(final Map<String, Object> input) { public Object updateEmpfehlungPrio(final Map<String, Object> input) {
// Auslesen der Parameter aus 'input' // Auslesen und Prüfen der Parameter aus 'input'
//int rid = (int) input.get("rid"); var rid = input.get("rid");
Object rid = input.get("rid"); if (null == rid || Integer.parseInt(rid.toString()) == 0) {
Object strDate = input.get("bd"); logger.error("Kein Parameter 'rid' angegeben, gebe 'false' zurück");
SQLQuery result = null; return false;
}
var strDate = input.get("bd");
if (null == strDate || !strDate.toString().matches("[\\d]{4}-[\\d]{2}-[\\d]{2}")) {
logger.error("Kein oder ungültiger Parameter 'bd' angegeben, gebe 'false' zurück");
return false;
}
//String strD = strDate.toString(); //String strD = strDate.toString();
//String CompareDate = strD.substring(1, 11); //String CompareDate = strD.substring(1, 11);
//DateFormat simpleDateFormat=new SimpleDateFormat("yyyy-MM-dd"); //DateFormat simpleDateFormat=new SimpleDateFormat("yyyy-MM-dd");
String sql;
try { try {
sql = "UPDATE prozedur SET beginndatum = '" + strDate + "' WHERE id = '" + rid + "' "; String sql = "UPDATE prozedur SET beginndatum = '" + strDate + "' WHERE id = '" + rid + "' ";
result = onkostarApi.getSessionFactory().getCurrentSession().createSQLQuery(sql); SQLQuery result = onkostarApi.getSessionFactory().getCurrentSession().createSQLQuery(sql);
result.executeUpdate(); result.executeUpdate();
return true; return true;
} catch (Exception e) { } catch (Exception e) {
return "Achtung: Ein Fehler ist aufgetreten, Änderung konnte nicht gespeichert werden!"; return "Achtung: Ein Fehler ist aufgetreten, Änderung konnte nicht gespeichert werden!";
//return null; //return null;

62
src/test/java/DNPM/DNPMHelperTest.java
View File

@ -2,6 +2,9 @@ package DNPM;
import DNPM.services.systemtherapie.SystemtherapieService; import DNPM.services.systemtherapie.SystemtherapieService;
import de.itc.onkostar.api.IOnkostarApi; import de.itc.onkostar.api.IOnkostarApi;
import org.hibernate.SQLQuery;
import org.hibernate.Session;
import org.hibernate.SessionFactory;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.api.extension.ExtendWith;
@ -13,12 +16,13 @@ import java.util.HashMap;
import java.util.Map; import java.util.Map;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.times; import static org.mockito.Mockito.*;
import static org.mockito.Mockito.verify;
@ExtendWith(MockitoExtension.class) @ExtendWith(MockitoExtension.class)
class DNPMHelperTest { class DNPMHelperTest {
private IOnkostarApi onkostarApi;
private SystemtherapieService systemtherapieService; private SystemtherapieService systemtherapieService;
private DNPMHelper dnpmHelper; private DNPMHelper dnpmHelper;
@ -28,6 +32,7 @@ class DNPMHelperTest {
@Mock IOnkostarApi onkostarApi, @Mock IOnkostarApi onkostarApi,
@Mock SystemtherapieService systemtherapieService @Mock SystemtherapieService systemtherapieService
) { ) {
this.onkostarApi = onkostarApi;
this.systemtherapieService = systemtherapieService; this.systemtherapieService = systemtherapieService;
this.dnpmHelper = new DNPMHelper(onkostarApi, systemtherapieService); this.dnpmHelper = new DNPMHelper(onkostarApi, systemtherapieService);
} }
@ -55,4 +60,57 @@ class DNPMHelperTest {
assertThat(actual).isNull(); assertThat(actual).isNull();
} }
@Test
void testShouldReturnFalseIfNoRidAndNoBdCallingUpdateEmpfehlungPrio() {
var actual = dnpmHelper.updateEmpfehlungPrio(new HashMap<>());
assertThat(actual).isEqualTo(false);
}
@Test
void testShouldReturnFalseIfNoRidCallingUpdateEmpfehlungPrio() {
var actual = dnpmHelper.updateEmpfehlungPrio(Map.of("bd", "2023-01-01"));
assertThat(actual).isEqualTo(false);
}
@Test
void testShouldReturnFalseIfNoBdCallingUpdateEmpfehlungPrio() {
var actual = dnpmHelper.updateEmpfehlungPrio(Map.of("rid", 1234));
assertThat(actual).isEqualTo(false);
}
@Test
void testShouldReturnTrueIfRidAndBdPresentCallingUpdateEmpfehlungPrio() {
var sessionFactory = mock(SessionFactory.class);
var session = mock(Session.class);
var query = mock(SQLQuery.class);
when(onkostarApi.getSessionFactory()).thenReturn(sessionFactory);
when(sessionFactory.getCurrentSession()).thenReturn(session);
when(session.createSQLQuery(anyString())).thenReturn(query);
var actual = dnpmHelper.updateEmpfehlungPrio(Map.of("rid", 1234, "bd", "2023-01-01"));
assertThat(actual).isEqualTo(true);
}
@Test
void testShouldCreateSqlQueryWithRidAndBdCallingUpdateEmpfehlungPrio() {
var sessionFactory = mock(SessionFactory.class);
var session = mock(Session.class);
var query = mock(SQLQuery.class);
when(onkostarApi.getSessionFactory()).thenReturn(sessionFactory);
when(sessionFactory.getCurrentSession()).thenReturn(session);
when(session.createSQLQuery(anyString())).thenReturn(query);
dnpmHelper.updateEmpfehlungPrio(Map.of("rid", 1234, "bd", "2023-01-01"));
var argumentCaptor = ArgumentCaptor.forClass(String.class);
verify(session, times(1)).createSQLQuery(argumentCaptor.capture());
assertThat(argumentCaptor.getValue()).isEqualTo("UPDATE prozedur SET beginndatum = '2023-01-01' WHERE id = '1234' ");
}
} }