refactor: code cleanup

src/checks/mod.rs

@@ -195,8 +195,7 @@ pub fn print() {
             .bold()
     );
 
-    for problem in vec![
-        Problem {
+    for problem in [Problem {
             code: "2023-0001",
             name: "Unterformular mit Markierung 'hat Unterformulare'",
             description: "  Aktuell gibt es keine Unterformulare in Unterformularen, daher\n  \
@@ -246,8 +245,7 @@ pub fn print() {
             Dieses Problem muss manuell behoben werden.
             ",
             fixable: false,
-        },
-    ] {
+        }] {
         println!("{problem}\n");
     }
 }

src/file_io.rs

@@ -84,9 +84,8 @@ impl InputFile {
             InputFile::Osb { filename, .. }
             | InputFile::Osc { filename, .. }
             | InputFile::Yaml { filename, .. }
-            | InputFile::Other { filename, .. } => filename,
+            | InputFile::Other { filename, .. } => filename.clone(),
         }
-        .to_string()
     }
 
     #[allow(unused_variables)]

src/model/data_catalogue.rs

@@ -106,7 +106,7 @@ impl Requires for DataCatalogue {
             .iter()
             .filter(|&entry| entry.property_catalogue.is_some())
             .map(|entry| match &entry.property_catalogue {
-                Some(entry) => entry.to_string(),
+                Some(entry) => entry.clone(),
                 _ => String::new(),
             })
             .collect::<HashSet<_>>()
@@ -141,7 +141,7 @@ impl Requires for DataCatalogue {
 
 impl FolderContent for DataCatalogue {
     fn get_library_folder(&self) -> String {
-        self.ordner.bibliothek.name.to_string()
+        self.ordner.bibliothek.name.clone()
     }
 }