refactor: extract command handling into functions

src/commands.rs

@@ -23,7 +23,7 @@ use crate::file_io::{FileError, FileReader, InputFile};
 use crate::model::onkostar_editor::OnkostarEditor;
 use crate::profile::Profile;
 use clap::CommandFactory;
-use clap_complete::generate;
+use clap_complete::{generate, Shell};
 use console::style;
 use dialoguer::Confirm;
 use quick_xml::se::Serializer;
@@ -36,6 +36,60 @@ use std::io::Write;
 use std::ops::Add;
 use std::path::{Path, PathBuf};
 
+pub fn handle(command: SubCommand) -> Result<(), Box<dyn Error>> {
+    match command {
+        SubCommand::Completion { shell } => handle_completion(shell),
+        SubCommand::List {
+            inputfile,
+            sorted,
+            filter,
+        } => handle_list(inputfile, sorted, filter)?,
+        SubCommand::Tree {
+            inputfile,
+            sorted,
+            filter,
+        } => handle_tree(inputfile, sorted, filter)?,
+        SubCommand::Modify {
+            inputfile,
+            profile,
+            outputfile,
+            compact,
+            sorted,
+            strip,
+            interactive,
+            fix,
+        } => handle_modify(
+            inputfile,
+            profile,
+            outputfile,
+            compact,
+            sorted,
+            strip,
+            interactive,
+            fix,
+        )?,
+        SubCommand::Diff {
+            inputfile_a,
+            inputfile_b,
+            strict,
+        } => handle_diff(&inputfile_a, &inputfile_b, strict)?,
+        SubCommand::Sha256Sum { inputfile } => handle_sha256sum(inputfile),
+        SubCommand::Check {
+            file,
+            list,
+            password,
+        } => handle_check(file, list, password),
+        #[cfg(feature = "unzip-osb")]
+        SubCommand::UnzipOsb {
+            file,
+            password,
+            dir,
+        } => handle_unzip_osb(&file, password, dir),
+    }
+
+    Ok(())
+}
+
 fn write_outputfile(filename: String, content: &String) -> Result<(), FileError> {
     OpenOptions::new()
         .read(false)
@@ -49,9 +103,7 @@ fn write_outputfile(filename: String, content: &String) -> Result<(), FileError>
     Ok(())
 }
 
-pub fn handle(command: SubCommand) -> Result<(), Box<dyn Error>> {
-    match command {
-        SubCommand::Completion { shell } => {
+fn handle_completion(shell: Shell) {
     let command = &mut Cli::command();
     generate(
         shell,
@@ -59,12 +111,14 @@ pub fn handle(command: SubCommand) -> Result<(), Box<dyn Error>> {
         command.get_name().to_string(),
         &mut std::io::stdout(),
     );
-        }
-        SubCommand::List {
-            inputfile,
-            sorted,
-            filter,
-        } => match InputFile::read(inputfile, None)? {
+}
+
+fn handle_list(
+    inputfile: String,
+    sorted: bool,
+    filter: Option<String>,
+) -> Result<(), Box<dyn Error>> {
+    match InputFile::read(inputfile, None)? {
         osc @ InputFile::Osc { .. } => {
             let mut content: OnkostarEditor = osc.try_into()?;
             if sorted {
@@ -121,12 +175,16 @@ pub fn handle(command: SubCommand) -> Result<(), Box<dyn Error>> {
                 "Nur OSB- und OSC-Dateien werden unterstützt".to_string(),
             )))
         }
-        },
-        SubCommand::Tree {
-            inputfile,
-            sorted,
-            filter,
-        } => match InputFile::read(inputfile, None)? {
+    }
+    Ok(())
+}
+
+fn handle_tree(
+    inputfile: String,
+    sorted: bool,
+    filter: Option<String>,
+) -> Result<(), Box<dyn Error>> {
+    match InputFile::read(inputfile, None)? {
         osc @ InputFile::Osc { .. } => {
             let mut content: OnkostarEditor = osc.try_into()?;
             if sorted {
@@ -138,28 +196,34 @@ pub fn handle(command: SubCommand) -> Result<(), Box<dyn Error>> {
             }
             OnkostarEditor::print_tree(&content);
         }
-            InputFile::Osb { filename, .. } => return Err(Box::new(FileError::Reading(
+        InputFile::Osb { filename, .. } => {
+            return Err(Box::new(FileError::Reading(
                 filename,
                 "Nur OSC-Dateien werden unterstützt. OSB-Dateien erzeugen eine zu lange Ausgabe."
                     .to_string(),
-            ))),
+            )))
+        }
         InputFile::Yaml { filename, .. } | InputFile::Other { filename, .. } => {
             return Err(Box::new(FileError::Reading(
                 filename,
                 "Nur OSC-Dateien werden unterstützt".to_string(),
             )))
         }
-        },
-        SubCommand::Modify {
-            inputfile,
-            profile,
-            outputfile,
-            compact,
-            sorted,
-            strip,
-            interactive,
-            fix,
-        } => {
+    }
+
+    Ok(())
+}
+
+fn handle_modify(
+    inputfile: String,
+    profile: Option<String>,
+    outputfile: Option<String>,
+    compact: bool,
+    sorted: bool,
+    strip: bool,
+    interactive: bool,
+    fix: bool,
+) -> Result<(), Box<dyn Error>> {
     let mut data: OnkostarEditor = InputFile::read(inputfile, None)?.try_into()?;
 
     if let Some(profile) = profile {
@@ -187,9 +251,7 @@ pub fn handle(command: SubCommand) -> Result<(), Box<dyn Error>> {
 
         sorted = matches!(
             Confirm::new()
-                        .with_prompt(
-                            "Sortiere Kataloge und Formulare nach Name und Abhängigkeiten?"
-                        )
+                .with_prompt("Sortiere Kataloge und Formulare nach Name und Abhängigkeiten?")
                 .default(sorted)
                 .interact(),
             Ok(true)
@@ -225,9 +287,8 @@ pub fn handle(command: SubCommand) -> Result<(), Box<dyn Error>> {
         serializer.indent(' ', 2);
     }
 
-            data.serialize(serializer).map_err(|_| {
-                FileError::Writing("Cannot serialize result".to_string(), String::new())
-            })?;
+    data.serialize(serializer)
+        .map_err(|_| FileError::Writing("Cannot serialize result".to_string(), String::new()))?;
 
     let output = &"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"
         .to_string()
@@ -244,25 +305,28 @@ pub fn handle(command: SubCommand) -> Result<(), Box<dyn Error>> {
         None => {
             println!("{output}");
         }
-            }
-        }
-        SubCommand::Diff {
-            inputfile_a,
-            inputfile_b,
-            strict,
-        } => {
+    };
+
+    Ok(())
+}
+
+fn handle_diff(inputfile_a: &str, inputfile_b: &str, strict: bool) -> Result<(), Box<dyn Error>> {
     println!(
         "Vergleiche Datei A ({}) mit Datei B ({})",
         style(&inputfile_a).yellow(),
         style(&inputfile_b).yellow()
     );
 
-            let data_a = &mut FileReader::<OnkostarEditor>::read(&inputfile_a)?;
-            let data_b = &mut FileReader::<OnkostarEditor>::read(&inputfile_b)?;
+    let data_a = &mut FileReader::<OnkostarEditor>::read(inputfile_a)?;
+    let data_b = &mut FileReader::<OnkostarEditor>::read(inputfile_b)?;
 
     data_a.print_diff(data_b, strict);
-        }
-        SubCommand::Sha256Sum { inputfile } => match fs::read(inputfile.clone()) {
+
+    Ok(())
+}
+
+fn handle_sha256sum(inputfile: String) {
+    match fs::read(inputfile.clone()) {
         Ok(content) => {
             let mut hasher = Sha256::new();
             hasher.update(content.as_slice());
@@ -280,12 +344,10 @@ pub fn handle(command: SubCommand) -> Result<(), Box<dyn Error>> {
         Err(err) => {
             eprintln!("{}", FileError::Reading(inputfile, err.to_string()));
         }
-        },
-        SubCommand::Check {
-            file,
-            list,
-            password,
-        } => {
+    }
+}
+
+fn handle_check(file: Option<String>, list: bool, password: Option<String>) {
     if list {
         print();
     } else {
@@ -310,17 +372,10 @@ pub fn handle(command: SubCommand) -> Result<(), Box<dyn Error>> {
             }
         }
     }
-        }
-        #[cfg(feature = "unzip-osb")]
-        SubCommand::UnzipOsb {
-            file,
-            password,
-            dir,
-        } => {
-            use crate::unzip_osb::unzip_osb;
-            unzip_osb(file.as_str(), dir.unwrap_or_default().as_str(), password)
-        }
-    }
-
-    Ok(())
+}
+
+#[cfg(feature = "unzip-osb")]
+fn handle_unzip_osb(file: &str, password: Option<String>, dir: Option<String>) {
+    use crate::unzip_osb::unzip_osb;
+    unzip_osb(file, dir.unwrap_or_default().as_str(), password);
 }