1
0
mirror of https://github.com/pcvolkmer/onkostar-plugin-dnpm.git synced 2025-07-02 01:02:55 +00:00

Issue #4: Studiennummer und Erkennung des Studientyps hinzugefügt

Der Studientyp wird anhand der Studiennummer erkannt

* `NCT`: Beginnt mit `NCT` (Groß-/Kleinschreibung ignioriert)
* `EUDRA_CT`: Entspricht: `YYYY-NNNNNN-CC`, dabei aufgeteilt in
  (Jahres-)Zahl, sechstelliger sequenzieller Nummer und zweistelliger Prüfziffer
* `UNKNOWN`: Keine Studiennummer angegeben oder entspricht keinem bekannten Schema
This commit is contained in:
2023-03-14 08:53:38 +01:00
parent 176c052119
commit ce222deba8
3 changed files with 87 additions and 11 deletions

View File

@ -17,31 +17,28 @@ public class DefaultStudienService implements StudienService {
@Override
public List<Studie> findAll() {
var sql = "SELECT property_catalogue_version.version_number, pcve.code, pcve.shortdesc, pcve.description FROM property_catalogue "
var sql = "SELECT property_catalogue_version.version_number, studie.studien_nummer, pcve.code, pcve.shortdesc, pcve.description FROM property_catalogue "
+ "JOIN property_catalogue_version ON property_catalogue.id = property_catalogue_version.datacatalog_id "
+ "JOIN property_catalogue_version_entry pcve ON property_catalogue_version.id = pcve.property_version_id "
+ "JOIN studie ON studie.property_version_entry = pcve.id "
+ "WHERE property_catalogue.name = 'OS.Studien' "
+ "AND studie.aktiv;";
+ "LEFT JOIN studie ON pcve.id = studie.property_version_entry "
+ "WHERE property_catalogue.name = 'OS.Studien' AND s.aktiv;";
return this.jdbcTemplate.query(sql, (resultSet, i) -> new Studie(
resultSet.getString(1),
resultSet.getString(2),
resultSet.getString(3),
resultSet.getString(4),
resultSet.getInt(0)
));
}
@Override
public List<Studie> findByQuery(String query) {
var sql = "SELECT property_catalogue_version.version_number, pcve.code, pcve.shortdesc, pcve.description FROM property_catalogue "
var sql = "SELECT property_catalogue_version.version_number, studie.studien_nummer, pcve.code, pcve.shortdesc, pcve.description FROM property_catalogue "
+ "JOIN property_catalogue_version ON property_catalogue.id = property_catalogue_version.datacatalog_id "
+ "JOIN property_catalogue_version_entry pcve ON property_catalogue_version.id = pcve.property_version_id "
+ "JOIN studie ON studie.property_version_entry = pcve.id "
+ "WHERE property_catalogue.name = 'OS.Studien' "
+ "AND studie.aktiv "
+ "AND (pcve.shortdesc LIKE ? "
+ "OR pcve.description LIKE ?);";
+ "LEFT JOIN studie ON pcve.id = studie.property_version_entry "
+ "WHERE property_catalogue.name = 'OS.Studien' AND studie.aktiv AND (pcve.shortdesc LIKE ? OR pcve.description LIKE ?);";
var like = String.format("%%%s%%", query);
@ -49,6 +46,7 @@ public class DefaultStudienService implements StudienService {
resultSet.getString(1),
resultSet.getString(2),
resultSet.getString(3),
resultSet.getString(4),
resultSet.getInt(0)
));
}

View File

@ -2,12 +2,14 @@ package DNPM.services;
public class Studie {
private final String code;
private final String studiennummer;
private final String shortDesc;
private final String description;
private final int version;
public Studie(final String code, final String shortDesc, final String description, final int version) {
public Studie(final String code, final String studiennummer, final String shortDesc, final String description, final int version) {
this.code = code;
this.studiennummer = studiennummer;
this.shortDesc = shortDesc;
this.description = description;
this.version = version;
@ -17,6 +19,10 @@ public class Studie {
return code;
}
public String getStudiennummer() {
return studiennummer;
}
public String getShortDesc() {
return shortDesc;
}
@ -28,4 +34,28 @@ public class Studie {
public int getVersion() {
return version;
}
public Type getType() {
if (this.hasNctNumber()) {
return Type.NCT;
} else if (this.hasEudraCtNumber()) {
return Type.EUDRA_CT;
} else {
return Type.UNKNOWN;
}
}
private boolean hasNctNumber() {
return null != studiennummer && studiennummer.toLowerCase().startsWith("nct");
}
private boolean hasEudraCtNumber() {
return null != studiennummer && studiennummer.matches("[0-9]{4}-[0-9]{6}-[0-9]{2}");
}
public enum Type {
NCT,
EUDRA_CT,
UNKNOWN
}
}

View File

@ -0,0 +1,48 @@
package DNPM.services;
import org.junit.jupiter.api.Test;
import static org.assertj.core.api.Assertions.assertThat;
public class StudieTest {
@Test
void shouldDetectStudieWithNctNumber() {
var studie = new Studie(
"teststudie1",
"Nct-12345678",
"Teststudie 1",
"Teststudie 1",
1
);
assertThat(studie.getType()).isEqualTo(Studie.Type.NCT);
}
@Test
void shouldDetectStudieWithEudraCtNumber() {
var studie = new Studie(
"teststudie1",
"2023-012345-12",
"Teststudie 1",
"Teststudie 1",
1
);
assertThat(studie.getType()).isEqualTo(Studie.Type.EUDRA_CT);
}
@Test
void shouldReturnStudieWithUnknownNumberScheme() {
var studie = new Studie(
"teststudie1",
null,
"Teststudie 1",
"Teststudie 1",
1
);
assertThat(studie.getType()).isEqualTo(Studie.Type.UNKNOWN);
}
}