pcvolkmer/onkostar-plugin-dnpm
1
0
Fork 0
mirror of https://github.com/pcvolkmer/onkostar-plugin-dnpm.git synced 2025-07-02 01:02:55 +00:00
Code Issues Activity

Issue #28: Fange Zugriffsfehler bei fehlender Berechtigung

Browse Source
This commit is contained in:
Paul-Christian Volkmer
2023-05-09 14:06:57 +02:00
parent de50c50eb4
commit b4c836f7ed
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/java/DNPM/analyzer/EinzelempfehlungAnalyzer.java
View File

@ -2,6 +2,7 @@ package DNPM.analyzer;
import DNPM.dto.Variant;
import DNPM.security.DelegatingDataBasedPermissionEvaluator;
import DNPM.security.IllegalSecuredObjectAccessException;
import DNPM.services.molekulargenetik.MolekulargenetikFormService;
import de.itc.onkostar.api.Disease;
import de.itc.onkostar.api.IOnkostarApi;
@ -9,6 +10,8 @@ import de.itc.onkostar.api.Procedure;
import de.itc.onkostar.api.analysis.AnalyzerRequirement;
import de.itc.onkostar.api.analysis.IProcedureAnalyzer;
import de.itc.onkostar.api.analysis.OnkostarPluginType;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.stereotype.Component;
import java.util.List;
@ -22,6 +25,8 @@ import java.util.Map;
@Component
public class EinzelempfehlungAnalyzer implements IProcedureAnalyzer {
private final static Logger logger = LoggerFactory.getLogger(EinzelempfehlungAnalyzer.class);
private final IOnkostarApi onkostarApi;
private final MolekulargenetikFormService molekulargenetikFormService;
@ -98,7 +103,12 @@ public class EinzelempfehlungAnalyzer implements IProcedureAnalyzer {
return List.of();
}
return molekulargenetikFormService.getVariants(procedure);
try {
return molekulargenetikFormService.getVariants(procedure);
} catch (IllegalSecuredObjectAccessException e) {
logger.error("Security", e);
return List.of();
}
}
}

2
src/main/java/DNPM/services/molekulargenetik/OsMolekulargenetikFormService.java
View File

@ -1,7 +1,6 @@
package DNPM.services.molekulargenetik;
import DNPM.dto.Variant;
import DNPM.security.FormSecured;
import DNPM.security.PersonPoolSecured;
import de.itc.onkostar.api.Procedure;
@ -12,7 +11,6 @@ import java.util.stream.Collectors;
public class OsMolekulargenetikFormService implements MolekulargenetikFormService {
@Override
@FormSecured
@PersonPoolSecured
public List<Variant> getVariants(Procedure procedure) {
if (! "OS.Molekulargenetik".equals(procedure.getFormName())) {